Skip to content

[CORE] Refactoring add functions from BaseLink and Link - #6129

Merged
fredroy merged 34 commits into
sofa-framework:masterfrom
Lucas-TJ:fix_add_from_link
Sep 23, 2026
Merged

fredroy merged 34 commits into
sofa-framework:masterfrom
Lucas-TJ:fix_add_from_link

Conversation

@Lucas-TJ

@Lucas-TJ Lucas-TJ commented May 27, 2026 •

Copy link
Copy Markdown
Contributor

Hello,

This PR is there to make the code of the add functions clearer in BaseLink and Link.

Later, I will add some unit tests.

Thank you

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels May 27, 2026
@fredroy

fredroy commented May 27, 2026

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests]

@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jun 4, 2026
Comment thread Sofa/framework/Core/src/sofa/core/objectmodel/Link.h Outdated
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jun 18, 2026
@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels Jul 16, 2026
@bakpaul

bakpaul commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests]

@alxbilger

Copy link
Copy Markdown
Contributor

@Lucas-TJ can you solve the conflicts?

hugtalbot and others added 5 commits July 30, 2026 16:23
* [v26.06] Add changelog  (sofa-framework#6180)

Add changelog for v26.06

* Bump version to v26.12.99

* forgotten build action

---------

Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…in for topology (sofa-framework#6212)

fix required plugin for TetrahedronHyperelasticityFEMForceField
* add doremove

* clean

* add unit test

* remove useless include
* Fix unit test for forcefeedback

* Fix forces values
)

Remove plugin from sources and add it to the preset
@Lucas-TJ Lucas-TJ added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jul 31, 2026
Comment thread Sofa/framework/Core/src/sofa/core/objectmodel/Link.h Outdated
@Lucas-TJ Lucas-TJ added topic for next dev-meeting PR to be discussed in sofa-dev meeting and removed topic for next dev-meeting PR to be discussed in sofa-dev meeting labels Jul 31, 2026
@Lucas-TJ

Copy link
Copy Markdown
Contributor Author

UPDATE - Changes about API

Reverting the previous changes to avoid any ambiguity with the existing API, but still allowing the use of the add function in my project, an addRawPtr function has been added.

This function allows adding a target (baseptr) to a link by taking only the baseptr as a parameter.

Thank you

@Lucas-TJ Lucas-TJ added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 14, 2026
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 23, 2026
@fredroy
fredroy merged commit 7c79cf5 into sofa-framework:master Sep 23, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants